3 comments:
File src/soc/mediatek/mt8183/emi.c:
if DUAL_FREQ_K
current_freqsel = freq_tbl[DRAM_DFS_SHUFFLE_3];
params = &freq_params[DRAM_DFS_SHUFFLE_3];
#else
current_freqsel = freq_tbl[DRAM_DFS_SHUFFLE_1];
params = &freq_params[DRAM_DFS_SHUFFLE_1];
#endif
int freq_index = DRAM_DFS_SHUFFULE_1;
if (CONFIG(MT8183_DRAM_DUAL_FREQ))
freq_index = DRAM_DFS_SHUFFLE_3;
current_freqsel = freq_tbl[freq_index];
params = &freq_params[freq_index];
Patch Set #7, Line 381: #if DUAL_FREQ_K
isn't this 'multiple frequency' than 'dual'?
I think we should change this to
static void dram_calibrate(int shuffle) {
const u8 *const freq_tbl = freq_shuffle;
if (CONFIG(MT8183_DRAM_EMCP)) {
freq_tbl = freq_shuffle_emcp;
}
current_freqsel = freq_tbl[shuffle];
params = &freq_params[shuffle];
dfs_init_for_calibration(params, current_freqsel);
do_calib(params, current_freqsel);
}
void mt_set_emi(...) {
if (CONFIG(MT8183_DRAM_MULTI_FREQUENCY)) {
dram_calibrate(DRAM_DFS_SHUFFLE_3);
dram_calibrate(DRAM_DFS_SHUFFLE_2);
}
dram_calibrate(DRAM_DFS_SHUFFLE_1);
after_calib();
}
File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:
Patch Set #7, Line 41: #define DUAL_FREQ_K 0
Move this to a KConfig.
To view, visit change 35164. To unsubscribe, or for help writing mail filters, visit settings.