John Zhao has uploaded this change for review.
soc/intel/apollolake: Sync fsp upd structure update
FSP 2.0.9 provides UPD interface to adjust integrated filter
value, usb3 LDO and pmic vdd2 voltage. Change coreboot upd
structure to sync with fsp 2.0.9 release.
BUG=b:123398358
CQ-DEPEND=CL:*817128
TEST=Verified yorp boots to kernel.
Change-Id: I3d17dfbe58bdc5222378459723da8e9ac0573510
Signed-off-by: John Zhao <john.zhao@intel.com>
---
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/chip.h
M src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h
3 files changed, 57 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/31131/1
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index afbb45c..dcd5d93 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -623,6 +623,21 @@
* Options to disable XHCI Link Compliance Mode.
*/
silconfig->DisableComplianceMode = cfg->DisableComplianceMode;
+
+ /*
+ * Options to change USB3 ModPhy setting for Integrated Filter value.
+ */
+ silconfig->ModPhyIfValue = cfg->ModPhyIfValue;
+
+ /*
+ * Options to bump USB3 LDO voltage with 40mv.
+ */
+ silconfig->ModPhyVoltageBump = cfg->ModPhyVoltageBump;
+
+ /*
+ * Options to adjust PMIC Vdd2 voltage.
+ */
+ silconfig->PmicVdd2Voltage = cfg->PmicVdd2Voltage;
#endif
}
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h
index b9c9dc5..5e9df67 100644
--- a/src/soc/intel/apollolake/chip.h
+++ b/src/soc/intel/apollolake/chip.h
@@ -168,6 +168,26 @@
* 0:FALSE(Default), 1:True.
*/
uint8_t DisableComplianceMode;
+
+ /* Options to change USB3 ModPhy setting for the Integrated Filter (IF)
+ * value. Default is 0 to not changing IF value (default: 0x12). Set
+ * value to change IF value for successful Chrome OS installation.
+ */
+ uint8_t ModPhyIfValue;
+
+ /* Options to bump USB3 LDO voltage with 40mv. Default is FALSE to not
+ * increasing LDO voltage. Set TRUE to increase LDO voltage with 40mv.
+ * 0:FALSE (default), 1:True.
+ */
+ uint8_t ModPhyVoltageBump;
+
+ /* Options to adjust PMIC Vdd2 voltage (default 1.2v) . Default is 0 to
+ * not adjusting Vdd2 voltage. Set value for Vdd2 voltage with 1.24v.
+ * PMIC Buck 5 control register configuration - IPC Configuration
+ * Upd for changing Vdd2 voltage configuration : I2C_Slave_Address
+ * (31:24) + Register_Offset (23:16) + OR Value (15:8) + AND Value (7:0)
+ */
+ uint32_t PmicVdd2Voltage;
};
typedef struct soc_intel_apollolake_config config_t;
diff --git a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h
index 18a43e2..97a40b6 100644
--- a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h
+++ b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h
@@ -1,6 +1,6 @@
/** @file
-Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
Redistribution and use in source and binary forms, with or without modification,
are permitted provided that the following conditions are met:
@@ -1721,7 +1721,25 @@
**/
UINT32 PmicPmcIpcCtrl;
-/** Offset 0x03AF
+/** Offset 0x03AF - ModPhyIfValue
+ Upd To modify the Integrated Filter (IF) value as 0x12(Default) for WIN and 0x16
+ for Chrome
+**/
+ UINT8 ModPhyIfValue;
+
+/** Offset 0x03B0 - ModPhyVoltageBump
+ ModPhyVoltageBump. 1: enable, 0: disable
+ $EN_DIS
+**/
+ UINT8 ModPhyVoltageBump;
+
+/** Offset 0x03B1 - Vdd2 Voltage configuration
+ Upd for changing Vdd2 Voltage configuration : I2C_Slave_Address (31:23) + Register_Offset
+ (23:16) + OR Value (15:8) + AND Value (7:0)
+**/
+ UINT32 PmicVdd2Voltage;
+
+/** Offset 0x03B5
**/
UINT8 ReservedFspsUpd[1];
} FSP_S_CONFIG;
@@ -1792,9 +1810,9 @@
**/
FSP_S_CONFIG FspsConfig;
-/** Offset 0x03B0
+/** Offset 0x03B6
**/
- UINT8 UnusedUpdSpace7[16];
+ UINT8 UnusedUpdSpace7[10];
/** Offset 0x03C0
**/
To view, visit change 31131. To unsubscribe, or for help writing mail filters, visit settings.