21 Dec
2022
21 Dec
'22
5:03 p.m.
Attention is currently required from: Tarun Tuli, Kangheui Won, Matt DeVillier, Eric Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70372 )
Change subject: mb/google/brya: add ACPI brightness controls for iGPU ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Wondering know will chromebook confused by linux driver? Since we use EC to control not GOP itself.
What controls backlight brightness on these devices? This patch enables an ACPI backlight device that changes the backlight brightness through the iGPU. The GOP driver has nothing to do with this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70372
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03bb7a7309476839c49d2e862a036d9e89800605
Gerrit-Change-Number: 70372
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Kwongnin Tin kwongnint@gmail.com
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 21 Dec 2022 17:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment