Frans Hendriks uploaded patch set #11 to this change.

View Change

soc/intel/braswell/chip.c: Configure LPSS devices in correct mode

LPSS (SIO 0/24/0 and 0/30/0) are configured to ACPI mode if 'lpss_acpi_mode' = '1' or
PcdEnableDma0/PcdEnableDma1 is configured in ACPI mode. When function 0 is configured in
ACPI mode, functions > 1 are not available on the PCI bus, even pcdEnableXXXXX is set to
PCI mode.
For SIO DMA0:
- HSUARTS ports not visible on PCI bus.
For SIO DMA1:
- I2C ports not visible on PCI bus.

Force 'function > 1' devices in ACPI mode when function 0 is configured in ACPI
mode.

Intel FSP documentation does not mention that PcdEnable* devices in LPSS supports ACPI
Mode (value 0x2). For these devices value '0x1' is used for PCI Mode.

BUG=N/A
TEST=Booting embedded Linux at Portwell PQ7-M107, LPSS device are configured in ACPI mode
when 'lpss_acpi_mode' = '1'. Could not verify using these devices, because no
devices/connections are available.

Change-Id: Ie271d8cb9f30f0c0ba538f1530cfb82f1306fea8
Signed-off-by: Frans Hendriks <fhendriks@eltan.com>
---
M src/soc/intel/braswell/chip.c
1 file changed, 23 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/29284/11

To view, visit change 29284. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie271d8cb9f30f0c0ba538f1530cfb82f1306fea8
Gerrit-Change-Number: 29284
Gerrit-PatchSet: 11
Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-MessageType: newpatchset