View Change
1 comment:
File src/lib/spd_bin.c:
Patch Set #7, Line 196:
You could also do:
switch (dram_type) {
case SPD_DRAM_DDR3:
name_ptr = (char *) &spd[DDR3_SPD_PART_OFF];
name_len = DDR3_SPD_PART_LEN;
break;
// ... others
}
if (spd_part_name_override) {
name_ptr = spd_name_part_override;
name_len = MIN(strlen(spd_part_name_override), name_len);
}
To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0
Gerrit-Change-Number: 45459
Gerrit-PatchSet: 7
Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Thu, 17 Sep 2020 21:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment