[coreboot-gerrit] Change in ...coreboot[master]: qclib: Differentiate between ES_1.0 and ES1.1 silicon

[Sricharan Ramabadhran (Code Review)]

Sricharan Ramabadhran has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon
......................................................................


Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_exec… 
File src/soc/qualcomm/qcs405/qclib_execute.c:

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_exec… 
PS12, Line 32: 0x0194D000
  nit: the rest of the file uses lower cases hex values
ok will change to be consistent


https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_exec… 
PS12, Line 32: #define TCSR_SOC_HW_VERSION 0x0194D000
             : #define ES_1_0 0x20140100
             : #define ES_1_1 0x20140101
  As long as we really only need them here, it's
okay-ish to keep them here, but the SoC revision real […]
The only reason as we have
done below is to pass the right PBL pointer to qclib



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84
Gerrit-Change-Number: 30903
Gerrit-PatchSet: 12
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Yuji Sasaki <sasakiy(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 08 Mar 2019 12:23:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment