Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30976 )
Change subject: mediatek/mt8183: Add I2C driver code
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/30976/6/src/soc/mediatek/mt8183/i2c.c
File src/soc/mediatek/mt8183/i2c.c:
https://review.coreboot.org/#/c/30976/6/src/soc/mediatek/mt8183/i2c.c@128
PS6, Line 128: assert(bus < I2C_BUS_NUMBER && bus != 7);
Could you please add a comment, where this requirement comes from?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a4d78b494819f45951f78e5a618021000cf3463
Gerrit-Change-Number: 30976
Gerrit-PatchSet: 6
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wang qii
Qii.Wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 Feb 2019 11:52:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment