Attention is currently required from: Kangheui Won.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 18: 14 ms on uncached data on nissa
The fact that this is 14ms both here and below is pretty conspicuous. […]
Good point, I did assume basically all the time was spent reading from memory, but I didn't think about the byte-by-byte vs 32-bit difference.
xxhash is still faster with caching (see the patchset 1 commit message). But as Tim commented this is probably because of OOO execution.
To view, visit change 67670. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b7848d1d05e555b61e0f1cb605550dfe3449c6d
Gerrit-Change-Number: 67670
Gerrit-PatchSet: 2
Gerrit-Owner: Reka Norman <rekanorman@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Reka Norman <rekanorman@google.com>
Gerrit-Attention: Kangheui Won <khwon@chromium.org>
Gerrit-Comment-Date: Tue, 20 Sep 2022 23:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment