Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev.
35 comments:
Patchset:
Rebased and fixed build issues and boot issues, and addressed some comments.
File Documentation/mainboard/apple/macbookpro8_1.md:
nit: 8 MiB
Done
File src/mainboard/apple/macbookpro8_1/Kconfig:
Patch Set #16, Line 16: select GFX_GMA_INTERNAL_IS_LVDS
Please drop
Done
Patch Set #16, Line 21: string
Remove the type as per CB:56553
Done
Patch Set #16, Line 22: apple/macbookpro8_1
This now needs to be surrounded in double quotes
Done
Patch Set #16, Line 25: string
Remove the type as per CB:56554
Done
config MAX_CPUS
int
default 8
Remove as per CB:41839
Done
File src/mainboard/apple/macbookpro8_1/acpi/ec.asl:
/*
* This file is part of the coreboot project.
*
* Copyright (c) 2019-2020 Evgeny Zinoviev <me@ch1p.io>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Please use SPDX license headers
Done
File src/mainboard/apple/macbookpro8_1/acpi/platform.asl:
/*
* This file is part of the coreboot project.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Please use SPDX license headers
Done
File src/mainboard/apple/macbookpro8_1/acpi_tables.c:
Patch Set #16, Line 18: #include <southbridge/intel/bd82x6x/nvs.h>
Needs update
Done
Patch Set #16, Line 20: global_nvs_t
Needs update
Done
File src/mainboard/apple/macbookpro8_1/cmos.default:
Patch Set #16, Line 3: Enable
`Disable` would make more sense
Done
File src/mainboard/apple/macbookpro8_1/cmos.layout:
Please indent with tabs.
Done
##
## This file is part of the coreboot project.
##
## This program is free software; you can redistribute it and/or modify
## it under the terms of the GNU General Public License as published by
## the Free Software Foundation; version 2 of the License.
##
## This program is distributed in the hope that it will be useful,
## but WITHOUT ANY WARRANTY; without even the implied warranty of
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
## GNU General Public License for more details.
##
Please use SPDX license headers
Done
# -----------------------------------------------------------------
# Status Register A
# -----------------------------------------------------------------
# Status Register B
# -----------------------------------------------------------------
# Status Register C
#96 4 r 0 status_c_rsvd
#100 1 r 0 uf_flag
#101 1 r 0 af_flag
#102 1 r 0 pf_flag
#103 1 r 0 irqf_flag
# -----------------------------------------------------------------
# Status Register D
#104 7 r 0 status_d_rsvd
#111 1 r 0 valid_cmos_ram
# -----------------------------------------------------------------
# Diagnostic Status Register
#112 8 r 0 diag_rsvd1
Please remove
Done
Patch Set #16, Line 38: #120 264 r 0 unused
Please remove
Done
Patch Set #16, Line 44: #390 2 r 0 unused?
Please remove
Done
Patch Set #16, Line 48: #392 3 r 0 unused
Please remove
Done
Patch Set #16, Line 50: #399 1 r 0 unused
Please remove
Done
# SandyBridge MRC Scrambler Seed values
896 32 r 0 mrc_scrambler_seed
928 32 r 0 mrc_scrambler_seed_s3
960 16 r 0 mrc_scrambler_seed_chk
Only used with MRC. […]
Done
File src/mainboard/apple/macbookpro8_1/devicetree.cb:
PANEL_PORT_LVDS
Done
register "c1_acpower" = "1"
register "c1_battery" = "1"
register "c2_acpower" = "3"
register "c2_battery" = "3"
register "c3_acpower" = "5"
register "c3_battery" = "5"
Needs to be updated: […]
Done
Patch Set #16, Line 32: subsystemid 0x8086 0x7270 inherit
I think you can move this inside the southbridge chip, put `subsystemid 0x106b 0x00db inherit` here […]
I tried that, putting `subsystemid 0x8086 0x7270 inherit` inside the `chip southbrige` section, but the build system complains about that being a syntax error. If that line was moved right before the chip section, would it override the `subsystem 0x106b 0x00db inherit` line that you suggested and work as intended?
Patch Set #16, Line 46: register "c2_latency" = "0x0065"
Remove as per CB:55212
Done
File src/mainboard/apple/macbookpro8_1/dsdt.asl:
/*
* This file is part of the coreboot project.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Please use SPDX license headers
Done
Patch Set #16, Line 18: 0x02, // DSDT revision: ACPI 2.0 and up
ACPI_DSDT_REV_2,
Done
Patch Set #16, Line 21: // OEM revision
autoport nonsense, please remove
Done
File src/mainboard/apple/macbookpro8_1/early_init.c:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2008-2009 coresystems GmbH
* Copyright (C) 2014 Vladimir Serbinenko
* Copyright (C) 2019-2020 Evgeny Zinoviev <me@ch1p.io>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; version 2 of
* the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Please use SPDX license headers
Done
void mainboard_early_init(int s3resume)
{
}
Can be removed
Done
File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads:
Patch Set #11, Line 30: Analog
You only need to keep Internal and the DP/HDMI groups, as per schematics.
Done
File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads:
--
-- This file is part of the coreboot project.
--
-- This program is free software; you can redistribute it and/or modify
-- it under the terms of the GNU General Public License as published by
-- the Free Software Foundation; either version 2 of the License, or
-- (at your option) any later version.
--
-- This program is distributed in the hope that it will be useful,
-- but WITHOUT ANY WARRANTY; without even the implied warranty of
-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-- GNU General Public License for more details.
--
Please use SPDX license headers
Done
Patch Set #16, Line 31: Internal
LVDS
Done
File src/mainboard/apple/macbookpro8_1/gpio.c:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2008-2009 coresystems GmbH
* Copyright (C) 2014 Vladimir Serbinenko
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; version 2 of
* the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Please use SPDX license headers
Done
File src/mainboard/apple/macbookpro8_1/hda_verb.c:
Patch Set #8, Line 21: Cirrus
Please expand the comment, thanks
Done
File src/mainboard/apple/macbookpro8_1/mainboard.c:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2019 Evgeny Zinoviev <me@ch1p.io>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Please use SPDX license headers
Done
To view, visit change 33151. To unsubscribe, or for help writing mail filters, visit settings.