Aaron Durbin (adurbin@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5304
-gerrit
commit eff750512793edb45b49f33e906c6d67772dcf2d Author: Aaron Durbin adurbin@chromium.org Date: Tue Feb 25 00:24:22 2014 -0600
coreboot: remove get_lb_mem() function
The get_lb_mem() is no longer used. Therefore, remove it.
Change-Id: I2d8427c460cfbb2b7a9870dfd54f4a75738cfb88 Signed-off-by: Aaron Durbin adurbin@chromium.org --- src/include/boot/coreboot_tables.h | 5 ----- src/lib/coreboot_table.c | 15 +-------------- 2 files changed, 1 insertion(+), 19 deletions(-)
diff --git a/src/include/boot/coreboot_tables.h b/src/include/boot/coreboot_tables.h index 9b87f3d..c4ad572 100644 --- a/src/include/boot/coreboot_tables.h +++ b/src/include/boot/coreboot_tables.h @@ -338,11 +338,6 @@ unsigned long write_coreboot_table( unsigned long low_table_start, unsigned long low_table_end, unsigned long rom_table_start, unsigned long rom_table_end);
-/* Routines to extract part so the coreboot table or information - * from the coreboot table. - */ -struct lb_memory *get_lb_mem(void); - void fill_lb_gpios(struct lb_gpios *gpios);
#endif /* COREBOOT_TABLES_H */ diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index cb7179d..667c685 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -354,18 +354,6 @@ static unsigned long lb_table_fini(struct lb_header *head) return (unsigned long)rec + rec->size; }
-/* Routines to extract part so the coreboot table or - * information from the coreboot table after we have written it. - * Currently get_lb_mem relies on a global we can change the - * implementation. - */ -static struct lb_memory *mem_ranges = NULL; - -struct lb_memory *get_lb_mem(void) -{ - return mem_ranges; -} - unsigned long write_coreboot_table( unsigned long low_table_start, unsigned long low_table_end, unsigned long rom_table_start, unsigned long rom_table_end) @@ -430,8 +418,7 @@ unsigned long write_coreboot_table(
/* No other memory areas can be added after the memory table has been * committed as the entries won't show up in the serialize mem table. */ - mem_ranges = lb_memory(head); - bootmem_write_memory_table(mem_ranges); + bootmem_write_memory_table(lb_memory(head));
/* Record our motherboard */ lb_mainboard(head);