Attention is currently required from: Tim Crawford, Jeremy Soller, Angel Pons.
1 comment:
File src/soc/intel/cannonlake/fsp_params.c:
Patch Set #7, Line 582: params->SiNumberOfSsidTableEntry = i;
Note that this approach will result in FSP programming the default SVID/SSID values when neither xHC […]
Meh, you are right.
It would be better to have only the lines that dereference the device node
inside the if, e.g.
ssid_table[i].reg = PCI_SUBSYSTEM_VENDOR_ID;
ssid_table[i].device = PCI_SLOT(PCH_DEVFN_XHCI);
ssid_table[i].function = PCI_FUNC(PCH_DEVFN_XHCI);
dev = pcidev_path_on_root(PCH_DEVFN_XHCI);
if (dev) {
ssid_table[i].svid = dev->subsystem_vendor;
ssid_table[i].ssid = dev->subsystem_device;
}
++i;
That would ensure that we always have the two entries, and if the devices
are disabled, the entries shouldn't hurt.
To view, visit change 49104. To unsubscribe, or for help writing mail filters, visit settings.