Attention is currently required from: Paul Menzel, Arthur Heymans. Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 )
Change subject: util/chromeos: Use the same inventory each time and verify checksums ......................................................................
Patch Set 5:
(3 comments)
File util/chromeos/crosfirmware.sh:
https://review.coreboot.org/c/coreboot/+/51144/comment/1636a9cc_85c535dd PS4, Line 34: https://web.archive.org/web/20210211071412/
I don't think this is a good idea. You generally want the latest version for your board. […]
However, you also want consistency and to make sure that the files aren't corrupted. Perhaps coreboot could host its own version of that inventory file? I could put it in the repo
EDIT: my logic here is that the inventory file contains data that is likely non-copyrightable anyway. then, every now and then, the files can be updated to whatever the newest version is from google
EDIT2: also, you can always just update the file
https://review.coreboot.org/c/coreboot/+/51144/comment/ab068cb1_dc180985 PS4, Line 45:
use tabs for indentation.
already sorted, in patch set 5
https://review.coreboot.org/c/coreboot/+/51144/comment/02582159_3eac7fc9 PS4, Line 142: echo "acaf7450481136e72a1ee6c4fe3a2dea992d028f ${CONF}" > "${CONF_SHA1_FILE}"
what is this?
This is the sha1sum of the inventory file on that archive link. It is put into a temporary file to then be used with sha1sum -c commad