Subrata Banik has uploaded this change for review.

View Change

soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sideband_msg()

This patch to fix KW issue due to msg, data and response pointers NULL
check fail.

Change-Id: I39324514079f240ba1683a04e579de85485299bf
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
---
M src/soc/intel/common/block/pcr/pcr.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28949/1

diff --git a/src/soc/intel/common/block/pcr/pcr.c b/src/soc/intel/common/block/pcr/pcr.c
index b8d798f..024059a 100644
--- a/src/soc/intel/common/block/pcr/pcr.c
+++ b/src/soc/intel/common/block/pcr/pcr.c
@@ -263,7 +263,10 @@
 	uint16_t sbi_status;
 	uint16_t sbi_rid;
 
-	assert(msg && data && response);
+	if (!msg || !data || !response) {
+		die("Pointer msg/ data/ response checked for NULL Fail!");
+		return -1;
+	}
 
 	switch (msg->opcode) {
 		case MEM_READ:

To view, visit change 28949. To unsubscribe, or for help writing mail filters, visit settings.