What’s the difference to `src/ec/quanta/it8518/`?

quanta/it8518 is used in google/stout

The EC is an IT8518 but (from what I can tell) is compatible with Lenovo interfaces.

While quanta/it8518 could be used, lenovo/h8 has support for ThinkPad ACPI interfaces that are used or useful on this board (function keys, thinkpad_acpi).
X131e Chromebook (google/stout) doesn't have function keys, so doesn't have any of the relevant ACPI methods.

So H8 is the most appropriate EC code to use. However, there are a few differences like this that need to be taken into account.

View Change


To view, visit change 31067. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a01f37a8b54889b55e92c501c9350e6c68bd57
Gerrit-Change-Number: 31067
Gerrit-PatchSet: 1
Gerrit-Owner: James Ye <jye836@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: James Ye <jye836@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 24 Jan 2019 11:55:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment