(5 comments)

What’s the difference to `src/ec/quanta/it8518/`?

quanta/it8518 is used in google/stout

The EC is an IT8518 but (from what I can tell) is compatible with Lenovo interfaces.

While quanta/it8518 could be used, lenovo/h8 has support for ThinkPad ACPI interfaces that are used or useful on this board (function keys, thinkpad_acpi).
X131e Chromebook (google/stout) doesn't have function keys, so doesn't have any of the relevant ACPI methods.

So H8 is the most appropriate EC code to use. However, there are a few differences like this that need to be taken into account.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 11:

    The IT8518e EC of this board uses some different ACPI methods compared to the
    regular Lenovo H8.
    

    Did you have documentation for that, or did you reverse engineer this?

    The ACPI code for the vendor BIOS differs from the coreboot H8 code. I experimentally verified this. So a bit of both?

• File src/mainboard/lenovo/x131e/ec.h:

  • Patch Set #1:

    Shouldn’t this go under `src/ec/…/it…/` like with `src/ec/quanta/it8518/ec. […]

    I'm not sure. Is it more appropriate for it to be `src/ec/lenovo/it8518/ec.h`?

To view, visit change 31067. To unsubscribe, or for help writing mail filters, visit settings.