Attention is currently required from: Jérémy Compostella, Krishna P Bhat D, Paul Menzel, Sridhar Siricilla.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577?usp=email )
Change subject: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
......................................................................
Patch Set 43:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/a7f41188_1d311a33 :
PS43, Line 760: if (cse_boot_to_rw(cse_bp_info) != CB_SUCCESS)
: return;
when we switch to RW we do a global reset , following which the condition in line 1201 may not be satisfied and would end up returning without doing a downgrade.
if (CONFIG(SOC_INTEL_CSE_LITE_DEFER_DOWNGRADE)) {
if (deferred_call && !downgrade_req)
return;
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74577?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8
Gerrit-Change-Number: 74577
Gerrit-PatchSet: 43
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Mon, 10 Jul 2023 17:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment