Attention is currently required from: Christian Walter, Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40465 )
Change subject: mb/gigabyte: Add GA-D510UD
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40465/comment/311b30ea_2caa877f
PS6, Line 11: M
I remember that the raminit is somewhat picky (when there are 2 DIMMs).
LGTM
File src/mainboard/gigabyte/ga-d510ud/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40465/comment/cd70863d_f846e101
PS7, Line 13: device pci 0.0 on end # Host Bridge
Pineview does not have PEG...
Oh I got confused by a devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40465
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2126c7d31e0d8a8f80df69fdcdcd202b87f219a4
Gerrit-Change-Number: 40465
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 01 Mar 2021 17:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment