Keith Short uploaded patch set #2 to this change.

View Change

libpayload/usb: Increase SET ADDRESS time-out to 5 s

The SET ADDRESS timeout was set to only 100 ms for the xHCI driver. The
USB specification indicates a maximum response time of 50 ms for the SET
ADDRESS request, but this does not account for propagation time of the
request through USB hubs.

Analysis of other USB host driver timeouts:
EHCI: 3 seconds
OHCI: 2 seconds
UHCI: 30 ms
DWC: 3 seconds

BUG=b:124730179
BRANCH=sarien
TEST=Build libpayload and depthcharge on sarien/arcada.
TEST=Without change replicate USB set address timeouts in depthcharge
when dock and 4K monitor connected (which includes a total of 4 USB
hubs). With timeout fix, depthcharge boots OS with no USB errors and
the same USB topology.

Change-Id: I53e3e67d893420e7c9e8b52c47dd0edb979e5468
Signed-off-by: Keith Short <keithshort@chromium.org>
---
M payloads/libpayload/drivers/usb/xhci_events.c
1 file changed, 6 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33671/2

To view, visit change 33671. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53e3e67d893420e7c9e8b52c47dd0edb979e5468
Gerrit-Change-Number: 33671
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Short <keithshort@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Keith Short <keithshort@chromium.org>
Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newpatchset