5 comments:
File src/soc/intel/common/block/graphics/graphics.c:
The only platform specific part seems to be the pointer in
the chip config. So we could also move the implementation
here and add a weak intel_igd_get_controller_info(dev) that
returns NULL.
File src/soc/intel/skylake/acpi/globalnvs.asl:
Patch Set #5, Line 73: BRTL, 32, // 0x54 - 0x57 Brightness Level
I don't see this used anywhere.
CSTE, 16, // 0x58 - 0x59 Current display state
NSTE, 16, // 0x5a - 0x5b Next display state
Why add this to GNVS? It seems they are only used in
ASL code. So wouldn't it be the same to just add them
as named variables? (e.g. `Name (CSTE, 0)`)
File src/soc/intel/skylake/graphics.c:
Add info on this value as comment. If possible make this as #define.
The `dev` here should be the same as the `dev` passed to
gma_ssdt() below...
Patch Set #5, Line 130: return NULL;
...and it should only be called when the device is enabled.
To view, visit change 32549. To unsubscribe, or for help writing mail filters, visit settings.