Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47971 )
Change subject: arch/x86: Top-align .text in bootblock
......................................................................
Patch Set 10: -Code-Review
(1 comment)
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/47971/comment/f2d41f08_7025dc92
PS10, Line 17: #if !CONFIG(FIXED_BOOTBLOCK_SIZE)
: . = BOOTBLOCK_TOP - PROGRAM_SZ;
: . = ALIGN(16);
: #endif
This soverrides the 'sanity check' on the bootblock size, that it remains below CONFIG_C_ENV_BOOTBLOCK_SIZE (as required on some platforms: Intel/APL, Qemu/i440fx)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47971
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64325bd633e1104853cfb928c7f801d94ff3045a
Gerrit-Change-Number: 47971
Gerrit-PatchSet: 10
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 19:58:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment