Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 10: change consolidates the clear logic into one spot.
Right, we should guard espi_setup in bootblock.c with !VBOOT_STARTS_BEFORE_BOOTBLOCK. […]
I think the problem is what part of PSP is doing the reconfiguration of eSPI. If it is PSP BL, then yes the above check makes sense. But, if it is ABL or PSP OS, then x86 will have to redo the configuration. That is the reason I had mentioned on one of the previous CLs that PSP ideally should not touch the eSPI controller at all or at least leave it back in the state as it found at reset.
To view, visit change 52064. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic57689e50febd29796d8ac8d99c81e41fee5b41c
Gerrit-Change-Number: 52064
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Fri, 02 Apr 2021 21:26:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel@chromium.org>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment