Patch Set 4:
Patch Set 4:
Patch Set 4:
Patrick, Aaron, Nico: Can you share your opinions on my comments in patch set 4, wrt. using Kconfig symbols as commandline parameters vs. deriving necessary data from ELF headers. And in general, about the placement of amdcompress under util/cbfstool and not integrating it with amdfwtool. Thanks.
It was my understanding that Marshall is updating the patchset further. As for amdfwtool amdcompress I'm not familiar with the requirements currently. However, the compression requirements are orthogonal to just building the bootblock correctly. If the bootblock is linked correctly I would expect we could pull symbols out for driving utilities. However, we should be aware that we would need to mark this memory (where bootblock resides) as reserved. Typically we do that through cbmem and ensuring these programs live in cbmem. However, bootblock wouldn't have cbmem up yet so we need to ensure the use memory is reserved (both bootblock and romstage) in order to handle everything correctly for s3 transit.
Correct, I have patches in the works nearly ready to push. However, I have been explicitly requested by multiple parties to hold that work and complete some other tasks first. I apologize for the delay. In the interim, please don't read too much into the state of these early patches which were designed to accommodate 2 different boot options, i.e. one for bootblock followed by romstage, and another combining the two. The new version will be significantly cleaner.
I really prefer deferring the decision on moving the compression into amdfwtool, and harvesting elf information for auto-generating the pointer's base and size. As mentioned in the makefile PS4 l.213, decisions made as vboot is developed could refined may require alterations to any work done in now amdfwtool.
Sounds good to me. I can proceed with bootblock size optimisations, just that amd/picasso will continue to use the static size in the makefiles. In the long run, I am not sure if amd/picasso needs Kconfig C_ENV_BOOTBLOCK_SIZE but we'll figure it out later.
To view, visit change 37490. To unsubscribe, or for help writing mail filters, visit settings.