build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47072 )
Change subject: cpu/x86/mp_init.c: Allocate the smm relocation stack on the heap
......................................................................
Patch Set 5:
(2 comments)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/47072/comment/d8f8f6a6_c8bb6ec2
PS5, Line 778: _Static_assert(CONFIG_HEAP_SIZE > CONFIG_MAX_CPUS * CONFIG_SMM_STUB_STACK_SIZE,
Comparisons should place the constant on the right side of the test
https://review.coreboot.org/c/coreboot/+/47072/comment/98522ff6_359b57c3
PS5, Line 788: .stack_top = (void *)((uintptr_t)smm_stacks + num_cpus * CONFIG_SMM_STUB_STACK_SIZE),
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47072
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I125d3aa6526c923e154c41e2d586557c7d8f56c3
Gerrit-Change-Number: 47072
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Feb 2021 21:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment