23 comments:
File src/mainboard/apple/macbookair5_2/Kconfig:
Patch Set #23, Line 31: default "pci8086,0166.rom"
Is the VBIOS tested?
Not on this machine yet
File src/mainboard/apple/macbookair5_2/acpi_tables.c:
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
These can be dropped
Done
Patch Set #23, Line 28: // the lid is open by default.
Please use C-style comments for consistency
Done
File src/mainboard/apple/macbookair5_2/devicetree.cb:
Patch Set #23, Line 2: register "gfx.did" = "{ 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 }"
This can be dropped
Done
0
Done
0
Done
0
Done
Patch Set #23, Line 44: register "docking_supported" = "0"
is zero, can be dropped
Done
Patch Set #23, Line 50: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
is zero, can be dropped
Done
Patch Set #23, Line 66: High Definition Audio Audio
Stereo audio again :^)
Done
File src/mainboard/apple/macbookair5_2/dsdt.asl:
#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB
#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB
#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Are these used?
No
Patch Set #23, Line 28: /* Some generic macros */
Please remove this comment. I killed it on a recent change.
Done
#include <southbridge/intel/bd82x6x/acpi/platform.asl>
/* global NVS and variables. */
#include <southbridge/intel/bd82x6x/acpi/globalnvs.asl>
#include <southbridge/intel/bd82x6x/acpi/sleepstates.asl>
Some of these are now under common
Done
File src/mainboard/apple/macbookair5_2/gma-mainboard.ads:
Patch Set #23, Line 30: Analog
This one is likely to be unused
Done
File src/mainboard/apple/macbookair5_2/gnvs.c:
See current patchset
Done
File src/mainboard/apple/macbookair5_2/hda_verb.c:
Patch Set #23, Line 21: Cirrus
Cirrus CS4206
Done
Patch Set #23, Line 24: 0x0000000b
Use decimal here
Done
Patch Set #23, Line 25: /* NID 0x01: Subsystem ID. */
All of the "NID" comments are of no use, they can be dropped
Done
Use decimal here as well
Done
Patch Set #23, Line 57: 0x80862806, /* Codec Vendor / Device ID: Intel */
Add a space between the two codecs
Done
Patch Set #23, Line 60: 0x00000004
Also decimal
Done
Also decimal
Done
Patch Set #23, Line 75: 0x00270500, /* Set PS to D0 on DAC1 */
Please correct this
Done
To view, visit change 32604. To unsubscribe, or for help writing mail filters, visit settings.