Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: soc/intel: Implement PCIe RP devicetree update based on LCAP ......................................................................
Patch Set 19:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35985/19/src/soc/intel/skylake/chip... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/35985/19/src/soc/intel/skylake/chip... PS19, Line 102: unsigned int inc
oh.. apparently this change is in an earlier dependency patch. I'll go try and track that one down.
I'm so confused. When I was doing diff between patchset 14 and 19 this file came up as being changed. I have no idea why, but my comments are here. I'll resolve those.
https://review.coreboot.org/c/coreboot/+/35985/19/src/soc/intel/skylake/chip... PS19, Line 102: unsigned int inc = PCI_DEVFN(0, 1);
I really think this is arithmetic on devfn is not good. […]
Ack
https://review.coreboot.org/c/coreboot/+/35985/19/src/soc/intel/skylake/chip... PS19, Line 133: func0->path.pci.devfn = dev->path.pci.devfn;
Why is the swap necessary?
Ack
https://review.coreboot.org/c/coreboot/+/35985/19/src/soc/intel/skylake/chip... PS19, Line 140: static void pcie_override_devicetree_after_silicon_init(void)
Is this file just showing an alternative approach to the common one?
Ack