6 comments:
File src/cpu/intel/model_206ax/Kconfig:
Patch Set #8, Line 39: CPU has support for Hyper-Threading
This option is seriously confusing. You want to select this only if you want to control HT with a CMOS option.
This also depends on CMOS settings.
File src/cpu/intel/model_206ax/acpi.c:
Patch Set #8, Line 29: msr_t msr;
Shouldn't this be on a separate patch?
File src/cpu/intel/model_206ax/bootblock.c:
Patch Set #8, Line 55: /* See if flex ratio is already set to nominal TDP ratio */
Why is this gone?
Patch Set #8, Line 18: #include <arch/io.h>
Maybe move these conditional includes below, to distinguish between unconditional and conditional inclusions?
Patch Set #8, Line 79: Bit 0 is ht disable
I'm not sure of what read_option returns if it can't find cmos options. If this is wired so that it defaults to HT enable, then the preprocessor can be dropped.
File src/mainboard/hp/2570p/Kconfig:
Patch Set #8, Line 27: select CPU_INTEL_HT
Why do you add a prompt to this Kconfig option, if it then gets selected anyway?
Note that this will result in weird things if not using cmos for settings.
To view, visit change 29669. To unsubscribe, or for help writing mail filters, visit settings.