Attention is currently required from: Cliff Huang, Karthik Ramasubramanian, Lance Zhao, Sangram K Y, Subrata Banik, Tim Wawrzynczak, Vidya Gopalakrishnan, Vinay Kumar.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/84570?usp=email )
Change subject: mb/google/brox: Pass PL4 address and data to kernel through ACPI table
......................................................................
Patch Set 4:
(1 comment)
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/84570/comment/bac0d18e_fac637ef?usp... :
PS4, Line 156:
PL4 is not controlled by DPTF. […]
ACK - Will make the code change to keep original pl4 value in soc_config or some other global structure instead of dptf struct - (same as the review comment by karthik for the earlier patch )
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84570?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I503178487740f5d32bd1d9523ee94c732f0583aa
Gerrit-Change-Number: 84570
Gerrit-PatchSet: 4
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Sangram K Y
sangram.k.y@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Sangram K Y
sangram.k.y@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 01 Oct 2024 12:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com