Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner.
View Change
3 comments:
File src/soc/qualcomm/sc7280/Kconfig:
Patch Set #5, Line 14: select CACHE_MRC_SETTINGS
Is this needed for UART config? Maybe we can move this to another more relevant CL to make this one […]
if we deleted this macro getting build errors. i keep this change as it is.
File src/soc/qualcomm/sc7280/Makefile.inc:
Patch Set #5, Line 9:
bootblock-$(CONFIG_SC7280_QSPI) += qspi.c
bootblock-y += clock.c
bootblock-y += gpio.c
bootblock-$(CONFIG_DRIVERS_UART) += uart_bitbang.c
Since these are being added to all stages, please use the "all-y +=" syntax.
Ack
File src/soc/qualcomm/sc7280/uart_bitbang.c:
To view, visit change 47284. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6c70f917a59e233f6ea518d9c39f73fe84991c3
Gerrit-Change-Number: 47284
Gerrit-PatchSet: 34
Gerrit-Owner: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney@codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka@qualcomm.corp-partner.google.com>
Gerrit-CC: Shelley Chen <shchen@google.com>
Gerrit-Attention: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen@google.com>
Gerrit-Attention: mturney mturney <mturney@codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Comment-Date: Mon, 26 Apr 2021 02:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen@google.com>
Comment-In-Reply-To: Ravi Kumar Bokka <c_rbokka@qualcomm.corp-partner.google.com>
Gerrit-MessageType: comment