Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43049 )
Change subject: [WIP] mb/google/kahlee,zork: Remove special GPIO_2 override ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: Felix commented in CB:42807
yeah, calling soc_route_sci in soc_gpio_hook is rather unexpected. as far as i've seen the code in soc_gpio_hook was added to make sure that if gpio 2 is configured as wake pin (pin mux setting 0) the corresponding sci gets configured. introducing a PAD_NF_SCI macro and using that instead of the PAD_NF + soc_gpio_hook magic for the wake pin would allow removing the soc_gpio_hook. do you want to look into that or do you want me to open in internal ticket to look into that later?