build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34064 )
Change subject: commonlib: Add header for multiboot ......................................................................
Patch Set 1:
(100 comments)
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... File src/commonlib/include/commonlib/multiboot.h:
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 100: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 102: multiboot_uint32_t magic; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 105: multiboot_uint32_t flags; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 108: multiboot_uint32_t checksum; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 111: multiboot_uint32_t header_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 112: multiboot_uint32_t load_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 113: multiboot_uint32_t load_end_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 114: multiboot_uint32_t bss_end_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 115: multiboot_uint32_t entry_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 118: multiboot_uint32_t mode_type; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 119: multiboot_uint32_t width; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 120: multiboot_uint32_t height; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 121: multiboot_uint32_t depth; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 126: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 127: multiboot_uint32_t tabsize; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 128: multiboot_uint32_t strsize; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 129: multiboot_uint32_t addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 130: multiboot_uint32_t reserved; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 136: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 137: multiboot_uint32_t num; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 138: multiboot_uint32_t size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 139: multiboot_uint32_t addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 140: multiboot_uint32_t shndx; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 145: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 147: multiboot_uint32_t flags; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 150: multiboot_uint32_t mem_lower; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 151: multiboot_uint32_t mem_upper; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 154: multiboot_uint32_t boot_device; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 157: multiboot_uint32_t cmdline; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 160: multiboot_uint32_t mods_count; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 161: multiboot_uint32_t mods_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 163: union please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 164: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 164: { open brace '{' following union go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 165: multiboot_aout_symbol_table_t aout_sym; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 166: multiboot_elf_section_header_table_t elf_sec; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 167: } u; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 170: multiboot_uint32_t mmap_length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 171: multiboot_uint32_t mmap_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 174: multiboot_uint32_t drives_length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 175: multiboot_uint32_t drives_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 178: multiboot_uint32_t config_table; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 181: multiboot_uint32_t boot_loader_name; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 184: multiboot_uint32_t apm_table; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 187: multiboot_uint32_t vbe_control_info; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 188: multiboot_uint32_t vbe_mode_info; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 189: multiboot_uint16_t vbe_mode; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 190: multiboot_uint16_t vbe_interface_seg; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 191: multiboot_uint16_t vbe_interface_off; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 192: multiboot_uint16_t vbe_interface_len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 194: multiboot_uint64_t framebuffer_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 195: multiboot_uint32_t framebuffer_pitch; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 196: multiboot_uint32_t framebuffer_width; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 197: multiboot_uint32_t framebuffer_height; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 198: multiboot_uint8_t framebuffer_bpp; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 202: multiboot_uint8_t framebuffer_type; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 203: union please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 204: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 204: { open brace '{' following union go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 205: struct please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 206: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 206: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 207: multiboot_uint32_t framebuffer_palette_addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 208: multiboot_uint16_t framebuffer_palette_num_colors; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 209: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 210: struct please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 211: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 211: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 212: multiboot_uint8_t framebuffer_red_field_position; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 213: multiboot_uint8_t framebuffer_red_mask_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 214: multiboot_uint8_t framebuffer_green_field_position; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 215: multiboot_uint8_t framebuffer_green_mask_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 216: multiboot_uint8_t framebuffer_blue_field_position; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 217: multiboot_uint8_t framebuffer_blue_mask_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 218: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 219: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 224: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 225: multiboot_uint8_t red; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 226: multiboot_uint8_t green; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 227: multiboot_uint8_t blue; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 231: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 232: multiboot_uint32_t size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 233: multiboot_uint64_t addr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 234: multiboot_uint64_t len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 240: multiboot_uint32_t type; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 245: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 247: multiboot_uint32_t mod_start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 248: multiboot_uint32_t mod_end; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 251: multiboot_uint32_t cmdline; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 254: multiboot_uint32_t pad; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 260: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 261: grub_uint16_t version; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 262: grub_uint16_t cseg; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 263: grub_uint32_t offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 264: grub_uint16_t cseg_16; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 265: grub_uint16_t dseg; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 266: grub_uint16_t flags; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 267: grub_uint16_t cseg_len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 268: grub_uint16_t cseg_16_len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34064/1/src/commonlib/include/commo... PS1, Line 269: grub_uint16_t dseg_len; please, no spaces at the start of a line