27 comments:
File src/soc/mediatek/mt8192/dramc_ana_init_config.c:
Patch Set #2, Line 541: case 4 :
space prohibited before that ':' (ctx:WxE)
Patch Set #2, Line 544: case 8 :
space prohibited before that ':' (ctx:WxE)
Patch Set #2, Line 1173: (((tr->ca_p2s_ratio>2)||(tr->dq_semi_open)) * (1 - tr->dq_ca_open))) :
spaces required around that '>' (ctx:VxV)
Patch Set #2, Line 1173: (((tr->ca_p2s_ratio>2)||(tr->dq_semi_open)) * (1 - tr->dq_ca_open))) :
spaces required around that '||' (ctx:VxV)
Patch Set #2, Line 1175: tr->ca_full_rate = (tr->dq_ca_open == 1) ? ((tr->ckr > 1)? 1 : 0) :
spaces required around that '?' (ctx:VxW)
Patch Set #2, Line 1178: tr->dq_ckdiv4_en = ( tr->dq_semi_open == 1) ? 0 :
space prohibited after that open parenthesis '('
Patch Set #2, Line 1179: ((((data_rate/2) < 1200) ? 1 : 0) * (1-tr->dq_ca_open)) ;
space prohibited before semicolon
Patch Set #2, Line 1182: dq_pick = (tr->dq_semi_open == 1) ? 0 : (data_rate/2) ;
space prohibited before semicolon
Patch Set #2, Line 1183: ca_pick = (tr->ca_semi_open == 1) ? ca_mckio*2 : ((ca_mckio>=pi_fmin) ?
spaces required around that '>=' (ctx:VxV)
Patch Set #2, Line 1184: ca_mckio : (( ca_mckio >= (pi_fmin/2)) ? ca_mckio*2 : ca_mckio *4));
need consistent spacing around '*' (ctx:WxV)
Patch Set #2, Line 1184: ca_mckio : (( ca_mckio >= (pi_fmin/2)) ? ca_mckio*2 : ca_mckio *4));
space prohibited after that open parenthesis '('
Patch Set #2, Line 1185: tr->ca_ckdiv4_en = ((ca_pick < 1200) ? 1 : 0) * ( 1- tr->dq_ca_open) ;
need consistent spacing around '-' (ctx:VxW)
Patch Set #2, Line 1185: tr->ca_ckdiv4_en = ((ca_pick < 1200) ? 1 : 0) * ( 1- tr->dq_ca_open) ;
space prohibited before semicolon
Patch Set #2, Line 1185: tr->ca_ckdiv4_en = ((ca_pick < 1200) ? 1 : 0) * ( 1- tr->dq_ca_open) ;
space prohibited after that open parenthesis '('
Patch Set #2, Line 1186: tr->ca_prediv_en = (data_rate >= 4800) ? 1 : 0 ;
space prohibited before semicolon
Patch Set #2, Line 1199: tr->semi_open_ca_pick_mck_ratio = ( mckio_semi == 0) ?
space prohibited after that open parenthesis '('
Patch Set #2, Line 1200: 0 : (ca_pick*tr->dq_p2s_ratio)/data_rate ;
space prohibited before semicolon
Patch Set #2, Line 1204: tr->dq_track_ca_en = 0 ;
space prohibited before semicolon
Patch Set #2, Line 1205: tr->pll_freq = ((dq_pick * 2 * (tr->dq_ckdiv4_en+1)) > (ca_pick * 2 *(tr->ca_ckdiv4_en + 1))) ?
line over 96 characters
Patch Set #2, Line 1205: tr->pll_freq = ((dq_pick * 2 * (tr->dq_ckdiv4_en+1)) > (ca_pick * 2 *(tr->ca_ckdiv4_en + 1))) ?
need consistent spacing around '*' (ctx:WxV)
Patch Set #2, Line 1225: ana_dll_sequence(dvfs_core,a_cfg);
space required after that ',' (ctx:VxV)
File src/soc/mediatek/mt8192/dramc_subsys_config.c:
Patch Set #2, Line 10: switch(freq_group) {
space required before the open parenthesis '('
Patch Set #2, Line 52: dfs_gp->ckr = 1;
code indent should use tabs where possible
Patch Set #2, Line 52: dfs_gp->ckr = 1;
please, no space before tabs
Patch Set #2, Line 52: dfs_gp->ckr = 1;
please, no spaces at the start of a line
Patch Set #2, Line 58: a_cfg->aphy_comb_en = 1 ;
space prohibited before semicolon
Patch Set #2, Line 100: a_cfg->tx_odt_dis = (freq_group <= DDRFREQ_1200) ? 1 : 0 ;
space prohibited before semicolon
To view, visit change 44727. To unsubscribe, or for help writing mail filters, visit settings.