Patch Set 2:

it seems like a better way to do it would be to edit sb/intel/common/Makefile.inc and move the conditional compilation for smbus.c outside of/above 'ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_COMMON),y)' and then add 'select SOUTHBRIDGE_INTEL_COMMON_SMBUS' to Braswell's Kconfig. I tested that this builds at least

Was thinking about this solution, but unsure about the impact on boards with
'SOUTHBRIDGE_INTEL_COMMON' disabled, but 'SOUTHBRIDGE_INTEL_COMMON_SMBUS' enabled.

View Change

To view, visit change 31661. To unsubscribe, or for help writing mail filters, visit settings.