EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48943 )
Change subject: soc/amd/picasso: Add STXS and CTXS method ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48943/2/src/soc/amd/common/acpi/gpi... File src/soc/amd/common/acpi/gpio_bank_lib.asl:
https://review.coreboot.org/c/coreboot/+/48943/2/src/soc/amd/common/acpi/gpi... PS2, Line 125: Tx
i'd say that "output" would be much clearer than "tx" here
Done
https://review.coreboot.org/c/coreboot/+/48943/2/src/soc/amd/common/acpi/gpi... PS2, Line 139: Tx
same
Done