Attention is currently required from: Christian Walter, Johnny Lin, Morgan Jang, Patrick Rudolph, Tim Chu.

Patch set 1:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Looks good to me. I don't like that the mainboard code needs boilerplate and will even successfully build if the boilerplate is missing due to weak function. That can be addressed separately though.

• File src/mainboard/bytedance/bd_egs/ramstage.c:

  • Patch Set #1, Line 28: smm_mainboard_pci_resource_store_init

    I would be nice to have a soc_ version of this or remove the weak version (Why would anyone select SMM_PCI_RESOURCE_STORE without a valid implementation?) so that the linker is at least unhappy when something is missing.

To view, visit change 80247. To unsubscribe, or for help writing mail filters, visit settings.