Felix Held submitted this change.

View Change



4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Daniel Peng: Looks good to me, but someone else must approve Derek Huang: Looks good to me, approved
mb/google/dedede/var/galtic: Correct name for mem-part K4U6E3S4AA-MGCR

Repo sync code recently, run command as memtioned in TEST and
found the changed for the auto-gen files.
Then correct the memory typo from K4UBE3D4AA-MGCR to K4U6E3S4AA-MGCR,
and no new for the used hex file.

BUG=b:320181366
BRANCH=firmware-dedede-13606.B
TEST=Run command "go run ./util/spd_tools/src/part_id_gen/\
part_id_gen.go JSL lp4x \
src/mainboard/google/dedede/variants/galtic/memory/ \
src/mainboard/google/dedede/variants/galtic/memory/\
mem_parts_used.txt"

Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41
Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79976
Reviewed-by: Derek Huang <derekhuang@google.com>
Reviewed-by: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc
M src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
M src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc b/src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc
index 7b9f433..b4a4e64 100644
--- a/src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc
+++ b/src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
+# /tmp/go-build591443712/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory/ src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt

SPD_SOURCES =
SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR
diff --git a/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
index 8d15cd9..73b84c1 100644
--- a/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
+++ b/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
@@ -1,11 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
+# /tmp/go-build591443712/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory/ src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt

DRAM Part Name ID to assign
H9HCNNNBKMMLXR-NEE 0 (0000)
MT53E512M32D2NP-046 WT:E 0 (0000)
-K4UBE3D4AA-MGCR 0 (0000)
+K4U6E3S4AA-MGCR 0 (0000)
MT53E1G32D2NP-046 WT:A 1 (0001)
H9HCNNNCPMMLXR-NEE 2 (0010)
diff --git a/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
index 03c8be0..52d4018 100644
--- a/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
+++ b/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
@@ -6,6 +6,6 @@
# Part Name
H9HCNNNBKMMLXR-NEE
MT53E512M32D2NP-046 WT:E
-K4UBE3D4AA-MGCR
+K4U6E3S4AA-MGCR
MT53E1G32D2NP-046 WT:A
H9HCNNNCPMMLXR-NEE

To view, visit change 79976. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41
Gerrit-Change-Number: 79976
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Frank Chu <frank_chu@pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin@pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu@pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged