Thejaswani, Any thoughts on my comments?
Patrick, I understand that you're not happy with not getting the documentation. Matt added the TEST=compiles line to the commit message. Since the board itself doesn't really exist yet, is this sufficient?
View Change
To view, visit change 34497. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I541952a4ef337e7277a85f02d25979f12ec075c4
Gerrit-Change-Number: 34497
Gerrit-PatchSet: 9
Gerrit-Owner: Thejaswani Putta <thejaswani.putta@intel.com>
Gerrit-Reviewer: AndreX Andraos <andrex.andraos@intel.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego@intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: John Zhao <john.zhao@intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mathew King <mathewk@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com>
Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Thejaswani Putta <thejaswani.putta@intel.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 21:05:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment