Patch Set 11:

Patch Set 11:

Why not make it part of inteltool? Yet another tool won't
make it easier to keep src/ and util/ sync'ed. If you
want to look into it, there is already a stale (out of
sync) commit on Gerrit for inteltool.

This would imply rewriting this tool in C. I don't think
it's too complex, but it's work that would need to be done.

Maybe this would fit better inside autoport? It happens to
be written in Go already, so rewriting would not be needed.

While this is absolutely great (thank you Maxim!), I too, vote for putting this functionality into inteltool (looking at the code it shouldn't be that much work):

Inteltool reads registers (integer) and outputs text; then intelp2m reads that text, parses it to integer, does some magic bit checking, and finally outputs that gpio.h. The whole parsing step could be completely skipped by implementing the conversion in inteltool. After looking at the code, I am pretty sure the whole thing can be thrown into inteltool as-is after replacing any Go-syntax by C-syntax.

View Change

To view, visit change 35643. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3e3b523c4f63dc2f91e9ccd16934e3a1b6e21fa
Gerrit-Change-Number: 35643
Gerrit-PatchSet: 11
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Maxim Polyakov <m.poliakov@yahoo.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Sun, 29 Sep 2019 16:29:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment