Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41215 )
Change subject: mb/google/volteer: Add firmware configuration table
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41215/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/fw_config.c:
https://review.coreboot.org/c/coreboot/+/41215/3/src/mainboard/google/voltee...
PS3, Line 90: volteer_fw_config
I need to make some changes here to support variants adding to (maybe overriding) the options within […]
Maybe similar to the gpio_configure_pads_with_override ? Provide a base configuration and then the variant can override specific defaults or callbacks?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I179f8b6436be83a2b37911777764bd26a0d404b7
Gerrit-Change-Number: 41215
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 15 May 2020 19:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment