6 comments:
File src/soc/intel/apollolake/cse.c:
Patch Set #11, Line 46: #define dump_status(index, hfs_reg) me_read_config32(hfs_reg)
Done
Done
File src/soc/intel/common/block/cse/cse.c:
Patch Set #2, Line 518: index = 1
for #1 refer to […]
Done
File src/soc/intel/common/block/cse/cse.c:
if (index != 0)
printk(BIOS_DEBUG, "CSE FWSTS%d: 0x%08x\n", index, reg);
else
printk(BIOS_DEBUG, "CSE [0x%x]=0x%08x\n", offset, reg);
why we need to print this everytime, leave it to caller ?
Done
Patch Set #13, Line 535: PCH_DEV_CSE
add DEV NULL check ?
Done
Patch Set #13, Line 537: if (!CONFIG(CONSOLE_SERIAL))
why we this guard?
Done
File src/soc/intel/common/block/include/intelblocks/cse.h:
no need for multi line comments
Done
To view, visit change 35225. To unsubscribe, or for help writing mail filters, visit settings.