View Change

5 comments:

• File src/mainboard/google/volteer/variants/eldrid/gpio.c:

  • Patch Set #11, Line 79: EN_PP3300_SD

    i think you'll want this in early_gpio as well.

• File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

  • Patch Set #11, Line 64:

    probe AUDIO MAX98357_ALC5682I_I2S
    					probe AUDIO MAX98373_ALC5682I_I2S
    

    your audio config is on the MLB and can't change, right?
    you won't need these probes.

  • Patch Set #11, Line 116: probe

    no need to probe if always on MLB.

  • Patch Set #11, Line 119:

    chip drivers/intel/soundwire
    				device generic 0 on
    					probe AUDIO MAX98373_ALC5682_SNDW
    					chip drivers/soundwire/alc5682
    						# SoundWire Link 0 ID 1
    						register "desc" = ""Headset Codec""
    						device generic 0.1 on end
    					end
    					chip drivers/soundwire/max98373
    						# SoundWire Link 1 ID 3
    						register "desc" = ""Left Speaker Amp""
    						device generic 1.3 on end
    					end
    					chip drivers/soundwire/max98373
    						# SoundWire Link 1 ID 7
    						register "desc" = ""Right Speaker Amp""
    						device generic 1.7 on end
    					end
    				end
    			end
    

    no soundwire on this board, right?

  • Patch Set #11, Line 157:

    probe DB_USB USB4_GEN2
    							probe DB_USB USB3_ACTIVE
    							probe DB_USB USB4_GEN3
    							probe DB_USB USB3_NO_A
    

    do you plan to support multiple USB DB types?

To view, visit change 44632. To unsubscribe, or for help writing mail filters, visit settings.