Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved EricR Lai: Looks good to me, approved
mb/google/drallion/variants/drallion: Update thermal configuration for DPTF

Follow thermal table for fine tuning.
1. Update PSV values for sensors.
2. Change PL1 min value from 4W to 5W.
3. Change PL1 max value from 15W to 12W.
4. Change PL2 min value from 15W to 12W.

BUG=b:148627484
TEST=Built and tested on drallion

Change-Id: I957d41e3c14f6dbcec8c3555382895698beabe40
Signed-off-by: John Su <john_su@compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38658
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
---
M src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl
index 4ecdf1a..6f114b7 100644
--- a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl
+++ b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl
@@ -19,19 +19,19 @@
/* Skin Sensor for CPU VR temperature monitor */
#define DPTF_TSR0_SENSOR_ID 1
#define DPTF_TSR0_SENSOR_NAME "Skin"
-#define DPTF_TSR0_PASSIVE 64
+#define DPTF_TSR0_PASSIVE 67
#define DPTF_TSR0_CRITICAL 127

/* Memory Sensor for DDR temperature monitor */
#define DPTF_TSR1_SENSOR_ID 2
#define DPTF_TSR1_SENSOR_NAME "DDR"
-#define DPTF_TSR1_PASSIVE 54
+#define DPTF_TSR1_PASSIVE 60
#define DPTF_TSR1_CRITICAL 127

/* M.2 Sensor for Ambient temperature monitor */
#define DPTF_TSR2_SENSOR_ID 3
#define DPTF_TSR2_SENSOR_NAME "Ambient"
-#define DPTF_TSR2_PASSIVE 40
+#define DPTF_TSR2_PASSIVE 90
#define DPTF_TSR2_CRITICAL 127

#undef DPTF_ENABLE_FAN_CONTROL
@@ -56,15 +56,15 @@
0x2, /* Revision */
Package () { /* Power Limit 1 */
0, /* PowerLimitIndex, 0 for Power Limit 1 */
- 4000, /* PowerLimitMinimum */
- 15000, /* PowerLimitMaximum */
+ 5000, /* PowerLimitMinimum */
+ 12000, /* PowerLimitMaximum */
100000, /* TimeWindowMinimum */
100000, /* TimeWindowMaximum */
100 /* StepSize */
},
Package () { /* Power Limit 2 */
1, /* PowerLimitIndex, 1 for Power Limit 2 */
- 15000, /* PowerLimitMinimum */
+ 12000, /* PowerLimitMinimum */
51000, /* PowerLimitMaximum */
280000, /* TimeWindowMinimum */
280000, /* TimeWindowMaximum */

To view, visit change 38658. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I957d41e3c14f6dbcec8c3555382895698beabe40
Gerrit-Change-Number: 38658
Gerrit-PatchSet: 5
Gerrit-Owner: John Su <john_su@compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: John Su <john_su@compal.corp-partner.google.com>
Gerrit-Reviewer: Mathew King <mathewk@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged