View Change
1 comment:
File src/lib/cbfs.c:
Patch Set #6, Line 301: if (cbmem_possibly_online() &&
do not use assignment in if condition
I'm planning to ignore these btw, unless anyone has strong feelings about it. These are kernel warnings and to my knowledge there's no hard rule about assignment expressions in the coreboot style. I feel it helps readability here to keep things compact and avoid further indentation.
To view, visit change 38423. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b1084bfdad1c6ab0ee1b143ed8dd796827f4c65
Gerrit-Change-Number: 38423
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Rob Barnes <robbarnes@google.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 06:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: comment