Over half the things you do in this patch are not related to variants.
18 comments:
File src/mainboard/lenovo/x201/Kconfig:
Patch Set #21, Line 21: select DRIVERS_LENOVO_HYBRID_GRAPHICS
no good on x201.
Patch Set #21, Line 25: select MAINBOARD_HAS_LIBGFXINIT
why move?
Patch Set #21, Line 47: DEVICETREE
use overridetrees
Patch Set #21, Line 72: ONBOARD_VGA_IS_PRIMARY
this override is only needed with DRIVERS_LENOVO_HYBRID_GRAPHICS
File src/mainboard/lenovo/x201/Makefile.inc:
romstage-$(CONFIG_BOARD_LENOVO_X201) += variants/x201/gpio.c
romstage-$(CONFIG_BOARD_LENOVO_T410) += variants/t410/gpio.c
are those not identical?
File src/mainboard/lenovo/x201/cmos.layout:
Patch Set #21, Line 79: hybrid_graphics_mode
you don't want bogus options on x201.
Patch Set #21, Line 82: 448 128 r 0 vbnv
please don't change lines that are not needed.
File src/mainboard/lenovo/x201/dock.c:
Patch Set #21, Line 41: Floating on T410
Don't do things that you know are not working. Also dock.asl needs fixing for t410.
const int gpio_num_array[] = {3, 4, 5, -1};
return get_gpios(gpio_num_array) != 7;
}
only change things needed please.
File src/mainboard/lenovo/x201/early_init.c:
Patch Set #21, Line 4: * Copyright (C) 2019 Patrick Rudolph
Not much copyrightable here but why change?
File src/mainboard/lenovo/x201/mainboard.c:
Patch Set #21, Line 7: * Copyright (C) 2019 Maciej Matuszczyk
you add a copyright line to remove a newline??
File src/mainboard/lenovo/x201/romstage.c:
#if CONFIG(BOARD_LENOVO_T410)
{ 1, IF1_557, 0 },
{ 1, IF1_55F, 1 },
{ 1, IF1_74B, 3 },
{ 1, IF1_14B, 3 },
{ 1, IF1_14B, 3 },
{ 1, IF1_74B, 3 },
{ 1, IF1_74B, 3 },
{ 1, IF1_74B, 3 },
{ 1, IF1_55F, 4 },
{ 1, IF1_55F, 5 },
{ 1, IF1_74B, 7 },
{ 1, IF1_74B, 7 },
{ 1, IF1_557, 7 },
{ 1, IF1_55F, 7 },
no preprocessor please.
Patch Set #21, Line 83: #if CONFIG(BOARD_LENOVO_X201) // Needed to make make happy
no preprocessor. if you don't want functions you should have the makefile deal with that.
Patch Set #21, Line 99: #if CONFIG(BOARD_LENOVO_X201)
no preprocessor.
File src/mainboard/lenovo/x201/smihandler.c:
Patch Set #21, Line 56: mdelay(250);
please only do things related to variants.
/* If EC wake events are enabled, enable wake on EC WAKE GPE. */
if (ec_wake & 0x14) {
/* Redirect EC WAKE GPE to SCI. */
Not needed?
File src/mainboard/lenovo/x201/thermal.h:
*
* Copyright (C) 2008-2009 coresystems GmbH
* Copyright (C) 2011 The Chromium OS Authors. All rights reserved.
* Copyright (C) 2014 Vladimir Serbinenko
* Copyright (C) 2016 Patrick Rudolph <siro@das-labor.org>
* Copyright (C) 2017 James Ye <jye836@gmail.com>
unrelated.
File src/mainboard/lenovo/x201/vboot-rwa.fmd:
SMMSTORE(PRESERVE) 0x40000
WP_RO {
RO_VPD(PRESERVE) 0x1000
RO_SECTION 0x11e000 {
unrelated?
To view, visit change 36871. To unsubscribe, or for help writing mail filters, visit settings.