Patch set 10:Code-Review +1

View Change

1 comment:

• File src/lib/fit_payload.c:

  • Patch Set #10, Line 78: memcpy(dst, node->data, node->size);

    This could result in a buffer overflow if region->size < node->size. […]

    I don't see how this would result in an error? true_size would still be non-zero, even if you didn't copy enough.

    It shouldn't really be possible for region->size to be smaller than node->size here. If you want a check, I'd just use assert().

To view, visit change 34535. To unsubscribe, or for help writing mail filters, visit settings.