Patch Set 10:

Patch Set 10:

Patch Set 10:

Hi Duncan & Shreesh, any update this week?

Patches have been at https://review.coreboot.org/c/coreboot/+/46262/9 but they need tested on real hardware.

Hi Duncan, your patch CL:46262 is not the complete implementation of D3Cold requirement. would you pls review this patch here, we need this patch in mainline soon

Could you indicate what is missing? My patch is implementing what is done here in the SSDT. We aren't going to merge static ASL code into the SOC which has dependencies on a mainboard-specific implementation.

View Change

To view, visit change 43600. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica28d6437a19f3e828b2320965866aba7f883898
Gerrit-Change-Number: 43600
Gerrit-PatchSet: 10
Gerrit-Owner: Shreesh Chhabbi <shreesh.chhabbi@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Shreesh Chhabbi <shreesh.chhabbi@intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alex Levin <levinale@google.com>
Gerrit-CC: Duncan Laurie <dlaurie@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Sukumar Ghorai <sukumar.ghorai@intel.com>
Gerrit-CC: Sukumar Ghorai <sukumar.ghorai@intel.corp-partner.google.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Fri, 30 Oct 2020 18:38:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment