Patch set 9:Code-Review +1
6 comments:
Some of the paragraphs might read better if you'd join them (generally,
there is no need to give every sentence its own paragraph).
Patch Set #9, Line 19: tested
double `tested`
Patch Set #9, Line 450: It might not be implemented for every framebuffer initialization platform.
Can we drop this now?
File src/lib/coreboot_table.c:
Patch Set #7, Line 150: if (CONFIG(BOOTSPLASH)) {
While I fully agree that that would be nice, I also think that it should not be handled now / in the […]
Sure, I was just leaving that thought, if anybody wants to take it,
it should be a separate patch (series?), ofc. I might start a discussion
on the ML about the API, but don't wait for me if I don't ;)
File src/lib/coreboot_table.c:
Patch Set #9, Line 152: size_t
`size_t` only works if it has the same size as a pointer by coincidence.
Better use `uintptr_t`.
Also, please remove the spaces around the parentheses. Then, it should
also fit on a single line. (You could also use `uint8_t` to save some
extra space.)
unsigned int?
To view, visit change 34599. To unsubscribe, or for help writing mail filters, visit settings.