View Change

10 comments:

• Commit Message:

  • Patch Set #11, Line 10:

    Please elaborate, what blob version you used for testing, and paste the newly added messages, and al […]

    Ack.

    measure/timings already exists, in CBFS:
    CBFS log: locating 'fallbak/dram', Found @ offset 2af40 size 1c50d.
    read ... 12802us

• File src/soc/mediatek/mt8192/Makefile.inc:

  • Patch Set #11, Line 41: dram

    I think, I’d be good to make that name configurable in Kconfig.

    The name "dram" won't modify, i think it can also stay here?

• File src/soc/mediatek/mt8192/memory.c:

  • Patch Set #11, Line 75: static int dram_run_full_calibration(struct dramc_param *dparam)

    Please measure the time of the blob execution (add CBMEM timestamps).

    Ack

  • Patch Set #11, Line 83: return -1;

    Please print an error message.

    Ack

  • Patch Set #11, Line 86: return -2;

    Please print an error message.

    Ack

  • Patch Set #11, Line 135: printk(BIOS_ERR, "Failed to run fast calibration\n");

    This with the new messages below is confusing. The return value should be printed.

    Ack

  • Patch Set #11, Line 149: Full Calibration

    Starting full calilbration …

    Ack

  • Patch Set #11, Line 149: DRAM-K

    What does DRAM-K stand for?

    stands for: dram calibration.

  • Patch Set #11, Line 153: printk(BIOS_INFO, "Full calibration passed\n");

    It should be prefixed with some RAM related term or be more elaborate.

    Ack

  • Patch Set #11, Line 160: }

    If the the different error codes are not considered (-1…-4), they shouldn’t be used.

    Ack

To view, visit change 44570. To unsubscribe, or for help writing mail filters, visit settings.