Attention is currently required from: Tarun Tuli, Kangheui Won, Eric Lai.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71690 )
Change subject: mb/google/nissa/var/craask: remove SAR UNUSED fw_config
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71690/comment/c59a8a94_e25b3b01
PS2, Line 23: field WIFI_SAR_ID 13 15
: option ID_0 0
: end
So get rid of the option and just hardcode it to option ID_0?
The stuff that's going on with these fields makes no sense to me. Yeah, value 7 wasn't used, because you can't get a 7 with just 2 bits. Why was that even added?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4298376899f881dd2265aef5a0bbc5bcc46728a1
Gerrit-Change-Number: 71690
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sun, 08 Jan 2023 01:14:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment