Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30364 )
Change subject: mb/google/hatch: Enable IGD (Integrated GFX Device)
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30364/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30364/1/src/mainboard/google/hatch/variants/...
PS1, Line 31: SkipExtGfxScan
just to confirm we don't want FSP to scan for external display ? […]
Yes
Most of google board has this UPD enabled. I think we don't want to enable external display during boot phase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I607199590d793a70e1e20bb3241fc34467aa829d
Gerrit-Change-Number: 30364
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 22 Dec 2018 07:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment