Angel Pons submitted this change.
vc/intel/fsp/fsp2_0/cpx_sp: Expose DIMM Present and DdrVoltage fields
The fields from SystemMemoryMapHob can be used to generate SMBIOS type 17.
Tested=On OCP Delta Lake, verify the values are expected.
Change-Id: I988e7341ddd3b701c698b41451a87890f21cc928
Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45797
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_memmap.h
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_memmap.h b/src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_memmap.h
index 7baa11a..dc870f1 100644
--- a/src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_memmap.h
+++ b/src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_memmap.h
@@ -89,7 +89,8 @@
} SYSTEM_MEMORY_MAP_ELEMENT;
typedef struct DimmDevice {
- UINT8 reserved1[2];
+ UINT8 Present;
+ UINT8 reserved1[1];
UINT8 DcpmmPresent;
UINT8 reserved2[1];
UINT8 NumRanks;
@@ -139,22 +140,24 @@
UINT32 memSize; // Total physical memory size
UINT16 memFreq; // Mem Frequency
- UINT8 reserved2[61];
+ UINT8 reserved2[22];
+ UINT8 DdrVoltage;
+ UINT8 reserved3[38];
UINT8 NumChPerMC;
UINT8 numberEntries; // Number of Memory Map Elements
SYSTEM_MEMORY_MAP_ELEMENT Element[(MAX_SOCKET * MAX_DRAM_CLUSTERS * MAX_SAD_RULES) + MAX_FPGA_REMOTE_SAD_RULES];
- UINT8 reserved3[2213];
+ UINT8 reserved4[2213];
MEMMAP_SOCKET Socket[MAX_SOCKET];
- UINT8 reserved4[1603];
+ UINT8 reserved5[1603];
UINT16 BiosFisVersion; // Firmware Interface Specification version currently supported by BIOS
- UINT8 reserved5[24];
+ UINT8 reserved6[24];
UINT32 MmiohBase; // MMIOH base in 64MB granularity
- UINT8 reserved6[5];
+ UINT8 reserved7[5];
} SYSTEM_MEMORY_MAP_HOB;
To view, visit change 45797. To unsubscribe, or for help writing mail filters, visit settings.