I'm not sure how to add DTS to a FIT image.
Currently, I got a FIT kernel image by:
$ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
$ mkimage -A arm64 -O linux -T kernel -C gzip -d vmlinux uImage
$ mkimage -f auto -A arm64 -O linux -T kernel -C none -a 40000000 -e 0 -c "Kernel 4.4 image for production devices" -d uImage fitImage

Also, linux kernel seems too big as a payload. How can I deal with that?
E: Could not add [fitImage, 304985299 bytes (297837 KB)@0x0]; too big?

View Change

10 comments:

• File src/mainboard/emulation/qemu-aarch64/Makefile.inc:

  • Patch Set #18, Line 27: bootblock-y += ../../../lib/bootblock.c

    If you have both of your CLs on the same Git branch (first that other CL, then this one) you can upl […]

    That's good to know! I rebased this CL on the CL 34250 and deleted the TODO comment and the bootblock-y line.

• File src/mainboard/emulation/qemu-aarch64/bootblock_custom.S:

  • Patch Set #16, Line 30: x19

    I mean you can call memcpy() from here, like this: […]

    I didn't notice that there is memcpy in src/arch/arm64/memcpy.S. It can be simpler. I think it doesn't affect the speed so I kept using memcpy. Thank you!

• File src/mainboard/emulation/qemu-aarch64/bootblock_custom.S:

  • Patch Set #18, Line 43: br x0

    nit: technically more correct would be 'blr'

    Ack

  • Patch Set #18, Line 45: after_relocate:

    You don't need this anymore

    Ack

• File src/mainboard/emulation/qemu-aarch64/devicetree.cb:

  • Patch Set #18, Line 8: chip drivers/generic/generic # I2C0 controller

    I still think this shouldn't be here. It doesn't do anything and doesn't refer to anything real. […]

    When I deleted this file or made this file empty, I got the error:
        (....)
        SCONFIG    mainboard/emulation/qemu-aarch64/devicetree.cb
    line 8: : syntax error
    make: *** [Makefile.inc:598: build/mainboard/emulation/qemu-aarch64/static.c] Error 1

• File src/mainboard/emulation/qemu-aarch64/mainboard.c:

  • Patch Set #18, Line 23: >> 10

    Prefer […]

    Ack

  • Patch Set #18, Line 23: VIRT_DRAM_BASE

    This should be (uintptr_t)_dram

    Ack

• File src/mainboard/emulation/qemu-aarch64/memlayout.ld:

  • Patch Set #18, Line 37: * 0x6111_0000..: TTB

    You shouldn't need extra comments to explain the layout if you just write this file itself to alread […]

    I removed lines from "0x0000_0000..0x0080_0000: Flash memory" to "0x6111_0000..: TTB".

  • Patch Set #18, Line 43: DRAM_START(VIRT_DRAM_BASE)

    No, sorry, this is still not what I meant. You should just write […]

    OK. I put on the number instead of using #define.

• File src/mainboard/emulation/qemu-aarch64/mmio.c:

  • Patch Set #18, Line 14: // TODO: Return VIRT_SECURE_UART_BASE when QEMU works on a secure mode.

    nit: please use /* C89 comments */, not // C99 comments […]

    I can get debug messages by VIRT_UART_BASE but coreboot doesn't output anything to my console by VIRT_SECURE_UART_BASE. So, I think QEMU uses the normal (non-secure) uart address. The TODO comment might be good to be removed.

To view, visit change 33387. To unsubscribe, or for help writing mail filters, visit settings.